Skip to content

RATY-357 stuck Dependabot workflows#481

Open
mikkojamG wants to merge 9 commits into
mainfrom
fix/RATY-357-stuck-dependabot-workflows
Open

RATY-357 stuck Dependabot workflows#481
mikkojamG wants to merge 9 commits into
mainfrom
fix/RATY-357-stuck-dependabot-workflows

Conversation

@mikkojamG

@mikkojamG mikkojamG commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description ✨

Solves multiple dependencies that are currently breaking Dependabot update workflows.

Issues 🐛

Closes 🙅‍♀️

DEV-XXX:

Related 🤝

Testing ⚗️

Automated tests ⚙️️

Manual testing 👷‍♂️

Screenshots 📸

Additional notes 🗒️

Summary by CodeRabbit

  • Chores
    • Updated the project’s tooling stack for a newer React/Vite/TypeScript and linting setup.
    • Improved workspace dependency handling for newer ESLint versions.
    • Adjusted build configuration to use the latest React integration and path resolution support.
  • Bug Fixes
    • Cleaned up several lint-related warnings to reduce noisy checks during development and testing.

@mikkojamG mikkojamG requested a review from a team as a code owner July 8, 2026 08:46
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@mikkojamG, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 852648ae-bd69-4edb-ac64-4428972e6b29

📥 Commits

Reviewing files that changed from the base of the PR and between e1e1e00 and ad251dd.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • sonar-project.properties
📝 Walkthrough

Walkthrough

This PR migrates ESLint configuration from eslint-plugin-react/eslint-plugin-import to @eslint-react/eslint-plugin and eslint-plugin-import-x, updates related dependencies in package.json and pnpm-workspace.yaml, switches Vite's React plugin and tsconfig path resolution, and adjusts eslint-disable comments across several source files.

Changes

Lint tooling migration and source annotations

Layer / File(s) Summary
ESLint flat config and dependency updates
eslint.config.mjs, package.json, pnpm-workspace.yaml
Replaces React/import lint plugins with @eslint-react and import-x, reworks React/react-hooks/jsx-a11y/import config blocks, updates the resolver key, bumps related dependency versions, and adds a peer dependency rule allowing ESLint 10.
Vite React plugin and tsconfig path resolution
vite.config.ts, tsconfig.json
Switches the Vite React plugin to @vitejs/plugin-react, replaces vite-tsconfig-paths with resolve.tsconfigPaths, and lowercases the moduleResolution value in tsconfig.json.
Source-level eslint-disable adjustments
src/common/components/modal/BaseDialogModal.tsx, src/common/components/table/Table.tsx, src/common/components/textInput/InputWrapper.tsx, src/domain/event/eventForm/useEventFormSubmitRequests.tsx, src/domain/app/routes/SilentRenewRedirect.tsx, src/domain/venue/venueDataFields/VenueDataFields.tsx, src/playwright/testWithFixtures.ts, src/common/components/notificationsContext/NotificationsContext.tsx
Adds new eslint-disable comments for @eslint-react rules, removes obsolete react-hooks eslint-disable comments no longer needed, and repositions a key prop in the notifications render loop.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: fixing dependency updates that were blocking Dependabot workflows.
Description check ✅ Passed The description matches the template and covers the main goal, but several sections are left empty or placeholder-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/RATY-357-stuck-dependabot-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
vite.config.ts (1)

4-5: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Prefer @vitejs/plugin-react-swc unless Babel-only transforms are required

@vitejs/plugin-react-swc is Vite 8-compatible and keeps JSX transforms on the faster SWC path. The resolve.tsconfigPaths and ESLint 10 concerns don’t block this setup, so the main tradeoff here is the React plugin swap.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@vite.config.ts` around lines 4 - 5, The Vite React setup is using the
Babel-based React plugin, but this should be switched to the SWC-based plugin
for better performance and Vite 8 compatibility. Update the import and plugin
usage in vite.config.ts from the current React plugin to
`@vitejs/plugin-react-swc`, and keep the rest of the Vite config unchanged unless
a Babel-only transform is actually needed.
eslint.config.mjs (1)

33-71: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Re-enable @eslint-react/dom-no-dangerously-set-innerhtml in the cleanup pass. It’s the only disabled rule here that directly guards against XSS; recommended-latest and disable-conflict-eslint-plugin-react-hooks are valid presets in the locked package versions.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@eslint.config.mjs` around lines 33 - 71, The cleanup override in
eslint.config.mjs is disabling `@eslint-react/dom-no-dangerously-set-innerhtml`
along with unrelated noisy rules, but this rule should be re-enabled. Update the
rules block in the config section that applies to the `@eslint-react` and
react-hooks presets so dom-no-dangerously-set-innerhtml is not turned off, while
keeping the valid recommended-latest and
disable-conflict-eslint-plugin-react-hooks preset usage intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Around line 37-58: The Vitest coverage dependency is out of sync with the
installed Vitest version, so update the `@vitest/coverage-v8` entry in
`package.json` to match the same patch line as `vitest`, or bump `vitest` and
the coverage plugin together so both stay aligned. Use the package names
`vitest` and `@vitest/coverage-v8` to locate and keep the test toolchain
versions consistent.

---

Nitpick comments:
In `@eslint.config.mjs`:
- Around line 33-71: The cleanup override in eslint.config.mjs is disabling
`@eslint-react/dom-no-dangerously-set-innerhtml` along with unrelated noisy rules,
but this rule should be re-enabled. Update the rules block in the config section
that applies to the `@eslint-react` and react-hooks presets so
dom-no-dangerously-set-innerhtml is not turned off, while keeping the valid
recommended-latest and disable-conflict-eslint-plugin-react-hooks preset usage
intact.

In `@vite.config.ts`:
- Around line 4-5: The Vite React setup is using the Babel-based React plugin,
but this should be switched to the SWC-based plugin for better performance and
Vite 8 compatibility. Update the import and plugin usage in vite.config.ts from
the current React plugin to `@vitejs/plugin-react-swc`, and keep the rest of the
Vite config unchanged unless a Babel-only transform is actually needed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 42622371-4476-4e4e-a5d7-d94e197ee0da

📥 Commits

Reviewing files that changed from the base of the PR and between 608c6be and e1e1e00.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (13)
  • eslint.config.mjs
  • package.json
  • pnpm-workspace.yaml
  • src/common/components/modal/BaseDialogModal.tsx
  • src/common/components/notificationsContext/NotificationsContext.tsx
  • src/common/components/table/Table.tsx
  • src/common/components/textInput/InputWrapper.tsx
  • src/domain/app/routes/SilentRenewRedirect.tsx
  • src/domain/event/eventForm/useEventFormSubmitRequests.tsx
  • src/domain/venue/venueDataFields/VenueDataFields.tsx
  • src/playwright/testWithFixtures.ts
  • tsconfig.json
  • vite.config.ts
💤 Files with no reviewable changes (3)
  • src/domain/app/routes/SilentRenewRedirect.tsx
  • src/domain/venue/venueDataFields/VenueDataFields.tsx
  • src/playwright/testWithFixtures.ts

Comment thread package.json
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

KULTUS-ADMIN-UI branch is deployed to platta: https://kultus-admin-ui-pr481.dev.hel.ninja 🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant